Add tests to verify incoming event type handler works #269
Conversation
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
===========================================
+ Coverage 62.24% 72.48% +10.24%
===========================================
Files 7 7
Lines 498 498
Branches 138 138
===========================================
+ Hits 310 361 +51
+ Misses 163 105 -58
- Partials 25 32 +7
Continue to review full report at Codecov.
|
seratch
changed the title
|
I've added more patterns in the second commit. The test coverage has been much improved 🙌 |
| respond: noop, | ||
| ack: noop, | ||
| }, | ||
| // TODO: https://github.com/slackapi/bolt/issues/263 |
There was a problem hiding this comment.
@shanedewael How about merging this PR before #276 and removing these comments out to verify your change works?
There was a problem hiding this comment.
Yes this is a good idea!
| app.action({ callback_id: 'message_action_callback_id' }, ({ }) => { actionFn(); }) | ||
| app.action({ callback_id: 'interactive_message_callback_id' }, ({ }) => { actionFn(); }) | ||
| app.action({ callback_id: 'dialog_submission_callback_id' }, ({ }) => { actionFn(); }) | ||
| app.view('view_callback_id', ({ }) => { viewFn(); }) |
There was a problem hiding this comment.
Should we add one for view_cancel? I can do this when we merge this before my branch lands.
There was a problem hiding this comment.
@shanedewael yes, we need to have it. I haven't added the one commented out yet as we didn't decide the design at that time.
Summary
This pull request adds a new test which verifies if handling incoming events works as expected. As you can see, Bolt now accepts
view_submissionadded by #261 while it cannot handleview_closedyet.Requirements (place an
xin each[ ])